Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: reduce startup time #753

Merged
merged 1 commit into from
Mar 1, 2023
Merged

perf: reduce startup time #753

merged 1 commit into from
Mar 1, 2023

Conversation

lewis6991
Copy link
Owner

No description provided.

@lewis6991 lewis6991 force-pushed the perf/startup branch 3 times, most recently from 1323a41 to 8398e61 Compare February 23, 2023 12:01
@lewis6991
Copy link
Owner Author

@clason can you test? For me this gets gitsigns down to 2ms (0.5ms cached) if there's no gitdir.

@lewis6991 lewis6991 force-pushed the perf/startup branch 5 times, most recently from 791e451 to e9971a9 Compare February 23, 2023 12:18
@clason
Copy link
Collaborator

clason commented Feb 23, 2023 •
edited
Loading

For me the difference is ~4.5ms to ~2ms (with cache), which is still a nice improvement.

(EDIT: it's ~6ms to ~3ms without cache.)

Probably due to my config?

@lewis6991 lewis6991 force-pushed the perf/startup branch 4 times, most recently from bfa5d2a to 724b523 Compare February 23, 2023 14:27
@lewis6991 lewis6991 marked this pull request as ready for review February 23, 2023 14:41
@lewis6991 lewis6991 mentioned this pull request Feb 27, 2023
Closed
@lewis6991 lewis6991 force-pushed the perf/startup branch 5 times, most recently from 2f542c0 to 8ffac04 Compare February 28, 2023 16:55
@dundargoc dundargoc mentioned this pull request Feb 28, 2023
Closed
@lewis6991 lewis6991 force-pushed the perf/startup branch 4 times, most recently from 60b4933 to 164fc85 Compare March 1, 2023 12:33
@lewis6991 lewis6991 merged commit f965e3b into main Mar 1, 2023
@lewis6991 lewis6991 deleted the perf/startup branch March 1, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lewis6991 @clason